hello I am an electric guitar player and I wanted to learn vocals so I should go for Indian classical or western?

It depends on which kind of music you prefer. If you have the desire to sit for 2hrs and do the proper riyaz only then opt for Indian classical. In western, it depends on how much improvisation you can do with your vocals and the breathing technique where it is very important. Still, if you want my suggestion, I would want you to listen to both performances for urself and then given your vocals decide which will fully satisfy your demand both aesthetically and from your voice quality. I would want you to devote your time to one particular style of music but would recommend you to listen to both performances. It will widen your understanding of music. For example, a folk singer should listen to country music or else he/she will not be able to improvise and hence after a while, his singing style will feel monotonous to the audiences. All the best for your musical journey read less